Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple DEX/Chain connector #103

Closed
fengtality opened this issue May 9, 2023 · 7 comments
Closed

Ripple DEX/Chain connector #103

fengtality opened this issue May 9, 2023 · 7 comments

Comments

@fengtality
Copy link
Contributor

Description

Bounty

@fengtality fengtality moved this to Open in Bounties Board May 9, 2023
@fengtality fengtality moved this from Open to Assigned in Bounties Board May 12, 2023
@mlguys
Copy link
Contributor

mlguys commented May 26, 2023

Hey, Im the current developer for this connector, will post my current status shortly.

@rapcmia
Copy link
Contributor

rapcmia commented May 31, 2023

Hi @mlguys good day to you
Can you please let us know any update for the ticket, also when can we review a PR? Thank you 🙇

@mlguys
Copy link
Contributor

mlguys commented Jun 1, 2023

Hey @rapcmia, I'm finishing the final component for the connector to be fully working on the gateway side. This component is the order tracking system which is used for tracking inflight or filled orders. Since Ripple SDK and the Ripple DEX doesn't support tracking filled orders, I had to make one in order to make the connector functional.

ETA for PR with would be this weekend. It should implement CLOBish clash and have tests that covers enough coverage requirements.

@nikspz
Copy link
Contributor

nikspz commented Jun 6, 2023

hi @mlguys, Do you have any updates on this bounty, and about when can we review a PR? Thanks

@mlguys
Copy link
Contributor

mlguys commented Jun 6, 2023

@nikspz, sorry for the delay, probably I will need one or two days more to push the PR.

@mlguys mlguys mentioned this issue Jun 8, 2023
4 tasks
@mlguys
Copy link
Contributor

mlguys commented Jun 8, 2023

Hey @nikspz @rapcmia, sorry for the delay, I have added the PR. The connector can be considered as finished at this moment but since the test coverage is still low, I will add more tests in the upcoming days to bring it up. These upcoming tests will include a integration test where it will simulate trading operations on testnet, I hope this will demonstrate how the connector work.

During the review, If you guys have question, feel free to ask!

@fengtality fengtality moved this to On Deck in Pull Request Status Jun 12, 2023
@fengtality fengtality moved this to On Deck in Pull Request Status Jun 12, 2023
@nikspz nikspz moved this from Assigned to Submitted in Bounties Board Jun 14, 2023
@fengtality fengtality moved this from Submitted to Needs Dev Work in Bounties Board Sep 21, 2023
@nikspz nikspz moved this from Needs Work to Submitted in Bounties Board Oct 6, 2023
@nikspz nikspz moved this from Submitted to Merged in Bounties Board Dec 5, 2023
@nikspz
Copy link
Contributor

nikspz commented Jan 16, 2024

Thanks for your participation, the bounty has been sent to wallet suggested by @mlguys . The connector has been deployed on client/gateway development branch and client/gateway hummingbot version 1.23.0.

@nikspz nikspz closed this as completed Jan 16, 2024
@github-project-automation github-project-automation bot moved this from Merged to Assigned in Bounties Board Jan 16, 2024
@nikspz nikspz moved this from Assigned to Paid in Bounties Board Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Paid
Development

No branches or pull requests

4 participants