Added match settings for manual procedures

huridocs · Dec 11, 2024 · aaf92c3 · aaf92c3
1 parent 49ee174
commit aaf92c3
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 6 deletions.
diff --git a/app/api/suggestions/specs/fixtures.ts b/app/api/suggestions/specs/fixtures.ts
@@ -117,6 +117,16 @@ const fixtures: DBFixture = {
       date: 5,
       page: 2,
       status: 'ready',
+      state: {
+        labeled: true,
+        obsolete: false,
+        match: true,
+        withValue: false,
+        withSuggestion: false,
+        processing: false,
+        error: false,
+        hasContext: false,
+      },
       error: '',
     },
     {
@@ -130,6 +140,16 @@ const fixtures: DBFixture = {
       date: 5,
       page: 2,
       status: 'ready',
+      state: {
+        labeled: true,
+        obsolete: false,
+        match: false,
+        withValue: false,
+        withSuggestion: false,
+        processing: false,
+        error: false,
+        hasContext: false,
+      },
       error: '',
     },
     {
@@ -1323,9 +1343,9 @@ const stateFilterFixtures: DBFixture = {
     factory.ixSuggestion({
       extractorId: factory.id('unused_extractor'),
       state: {
-        labeled: true,
         match: true,
         obsolete: true,
+        labeled: true,
         error: true,
       },
     }),

diff --git a/app/api/suggestions/specs/suggestions.spec.ts b/app/api/suggestions/specs/suggestions.spec.ts
@@ -1541,7 +1541,7 @@ describe('suggestions', () => {
       const query = { entityId: 'shared1' };
       await Suggestions.setObsolete(query);
       const obsoletes = await db.mongodb?.collection('ixsuggestions').find(query).toArray();
-      expect(obsoletes?.every(s => s.state.obsolete)).toBe(true);
+      expect(obsoletes?.every(s => s.state.obsolete && s.state.match === null)).toBe(true);
       expect(obsoletes?.length).toBe(4);
     });
   });
@@ -1555,7 +1555,7 @@ describe('suggestions', () => {
       const query = { entityId: 'shared1' };
       await Suggestions.markSuggestionsWithoutSegmentation(query);
       const notSegmented = await db.mongodb?.collection('ixsuggestions').find(query).toArray();
-      expect(notSegmented?.every(s => s.state.error)).toBe(true);
+      expect(notSegmented?.every(s => s.state.error && s.state.match === null)).toBe(true);
     });
 
     it('should not mark suggestions when segmentations are correct', async () => {
@@ -1572,7 +1572,7 @@ describe('suggestions', () => {
       expect(segmented?.length).toBe(1);
       expect(segmented?.every(s => s.state?.error)).toBe(false);
       expect(notSegmented?.length).toBe(1);
-      expect(notSegmented?.every(s => s.state.error)).toBe(true);
+      expect(notSegmented?.every(s => s.state.error && s.state.match === null)).toBe(true);
     });
   });
 
@@ -1612,13 +1612,15 @@ describe('suggestions', () => {
         ...newErroringSuggestion,
         state: {
           error: true,
+          match: null,
         },
       });
       expect(await findOneSuggestion({ entityId: newProcessingSuggestion.entityId })).toMatchObject(
         {
           ...newProcessingSuggestion,
           state: {
             processing: true,
+            match: null,
           },
         }
       );

diff --git a/app/api/suggestions/suggestions.ts b/app/api/suggestions/suggestions.ts
@@ -277,7 +277,9 @@ const Suggestions = {
   updateStates,
 
   setObsolete: async (query: any) =>
-    IXSuggestionsModel.updateMany(query, { $set: { 'state.obsolete': true } }),
+    IXSuggestionsModel.updateMany(query, {
+      $set: { 'state.obsolete': true, 'state.match': null },
+    }),
 
   markSuggestionsWithoutSegmentation: async (query: any) => {
     const segmentedFilesIds = await getSegmentedFilesIds();
@@ -286,7 +288,7 @@ const Suggestions = {
         ...query,
         fileId: { $nin: segmentedFilesIds },
       },
-      { $set: { 'state.error': true } }
+      { $set: { 'state.error': true, 'state.match': null } }
     );
   },