-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forcing the query limit to more than the hardcoded 10.000k crashes the request #2841
Comments
This has been proven not to be the case. It just stalls in answering and gives the 'wrong' maintenance screen. It happens at the exact 10,000 to 10,001 threshold. If you ask for limit:10001, it stalls and presents the maintenance screen. Still, the server (and that instance) remains responsive, and others can do normal queries without delay or the node loop being blocked. |
Connected to #2708 |
I propose we close this issue, and leave this one open: #2708 |
The request wasn't crashing. The server was simply not handling the request until it timed out. Now if users try to access this URL by reloading, instead of a UI error, they will receive a plain HTML error message. |
I don't see how we solved this 🤔 |
This problem only happened under these conditions:
Now this will trigger a server side rendering error. Previously it would just timeout. It has never been a bug. |
I think the name of this issue is somewhat misleading. The fix is that querying for 10.001 no longer crashes when loading the page. We have not yet fixed the issue of actually returning more than 10.000 documents. Still, we should not ever do that. We need to implement proper pagination and server replies that report that “there are more records” so you can program several queries to fetch all the records. Getting more than 10.000 is not the way to go. Just to clarify what was fixed here. |
@RafaPolit could we create a ticket (that we don't have to prioritize anytime soon), that would address the underlying problem in the fullest? |
Addressing #2708 probably fixes this. I have added a small note there to take that scenario into account. |
Forcing a query limit form 60 to ie. 60000
leaves the server unresponsive.(crashes the request)The text was updated successfully, but these errors were encountered: