Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download no longer respecting original filename #3092

Closed
RafaPolit opened this issue Aug 4, 2020 · 3 comments · Fixed by #3184
Closed

Download no longer respecting original filename #3092

RafaPolit opened this issue Aug 4, 2020 · 3 comments · Fixed by #3184
Assignees

Comments

@RafaPolit
Copy link
Member

The Download of the main PDF file has changed behaviors. It now acts very much like what is being requested in #2068 (for which approach I don't agree, but that is besides the point here).

Upon hitting the download button, there is a new window opened with the file (instead of a Download dialog), but the name of the file is our serialized PDF name and not the original filename of the uploaded document.

Losing the original filename is not expected, and the resulting name is completely useless in terms of semantics and storing procedures.

Even if we are keeping this route of opening a new tab instead of having the download button actually download!, the original name should be kept.

cc @txau

@txau
Copy link
Collaborator

txau commented Aug 6, 2020

Regarding the default behavior it was changed to open in new window instead of download since it gives more freedom to user to decide what to do with the file. Forcing the download won't let them just visualize the raw file while opening in new window let's them save the file when loaded (if they want to) or just right click on the download button and choose "save file".

The file naming should be fixed.

@RafaPolit
Copy link
Member Author

RafaPolit commented Aug 6, 2020

Ok. But then should the button say something different to "download"?

But yes, the key aspect of the issue is the naming problem.

@txau
Copy link
Collaborator

txau commented Aug 7, 2020

@RafaPolit it depends because keep in mind that the behavior of the button is controlled by your browser. If your browser can handle the mimetype it will display the document, if not, it will force the download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants