Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various lively wallpaper issues #487

Merged
merged 6 commits into from
Nov 26, 2024
Merged

fix: various lively wallpaper issues #487

merged 6 commits into from
Nov 26, 2024

Conversation

huynhsontung
Copy link
Owner

@huynhsontung huynhsontung commented Nov 18, 2024 •
edited
Loading

  • Normalized hostname argument for WebView2.NavigateToLocalPath() and handle exceptions if occurs.
  • Simplified Lively wallpaper installs using less async methods and reusing ZipArchive references.
  • Propagate Lively related exceptions to app notifications instead of passing them.
  • Move all JavaScript integration code and track change logic in the LivelyWallpaperPlayerViewModel.

@huynhsontung huynhsontung marked this pull request as ready for review November 26, 2024 07:50
@huynhsontung huynhsontung merged commit 92da3a5 into main Nov 26, 2024
4 checks passed
@huynhsontung huynhsontung deleted the fix-visualizer-issues branch November 26, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@huynhsontung