-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intent to implement: State-specific holidays #8
Comments
I'm thinking of a different approach for this: user selects the country, we load all of that country's holidays and then let the user selectively enable/disable individual holidays via the UI. |
If you look at #9, there are quite a few state-specific holidays (Australia) and it'd be tedious for the user to choose. If we know which holiday applies to which state, why not use that information? |
Ok, sure! Please note I'm merging the other in-development features to the |
Thanks, I've based my branch on #10 so will open a PR as soon as that's merged. |
In some countries each state decides their holidays more or less independently. Would you be interested in a PR that adds an optional state selector for those?
The text was updated successfully, but these errors were encountered: