Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intent to implement: State-specific holidays #8

Closed
koterpillar opened this issue Jan 7, 2023 · 4 comments
Closed

Intent to implement: State-specific holidays #8

koterpillar opened this issue Jan 7, 2023 · 4 comments

Comments

@koterpillar
Copy link
Contributor

In some countries each state decides their holidays more or less independently. Would you be interested in a PR that adds an optional state selector for those?

@hvianna
Copy link
Owner

hvianna commented Jan 8, 2023

I'm thinking of a different approach for this: user selects the country, we load all of that country's holidays and then let the user selectively enable/disable individual holidays via the UI.

@koterpillar
Copy link
Contributor Author

If you look at #9, there are quite a few state-specific holidays (Australia) and it'd be tedious for the user to choose. If we know which holiday applies to which state, why not use that information?

@hvianna
Copy link
Owner

hvianna commented Jan 10, 2023

Ok, sure! Please note I'm merging the other in-development features to the dev branch, so use that as the base branch, please.

@koterpillar
Copy link
Contributor Author

Thanks, I've based my branch on #10 so will open a PR as soon as that's merged.

@koterpillar koterpillar mentioned this issue Jan 10, 2023
@hvianna hvianna closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants