Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evap: Slight inconsistency between possible sunshine duration and extraterrestrial radiation #82

Open
tyralla opened this issue Feb 17, 2022 · 0 comments

Comments

@tyralla
Copy link
Member

tyralla commented Feb 17, 2022

See the fourth line in the "hourly simulation" integration test. Possibly not a big deal, but we should investigate the reason later.

There is already (a related?) critical discussion in the documentation on method Calc_ExtraterrestrialRadiation_V1.

My first guess is, that using the max function is too simple and causes inconsistency with the possibly sunshine duration:

            flu.extraterrestrialradiation = max(
                12.0
                * 4.92
                / d_pi
                * flu.earthsundistance
                * (
                    (
                        (d_omega2 - d_omega1)
                        * modelutils.sin(der.latituderad)
                        * modelutils.sin(flu.solardeclination)
                    )
                    + (
                        modelutils.cos(der.latituderad)
                        * modelutils.cos(flu.solardeclination)
                        * (modelutils.sin(d_omega2) - modelutils.sin(d_omega1))
                    )
                ),
                0.0,
            )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant