Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoundLogger for stdlib wrapper lacks .log() method #36

Closed
wbolster opened this issue Jan 15, 2015 · 7 comments · Fixed by #42
Closed

BoundLogger for stdlib wrapper lacks .log() method #36

wbolster opened this issue Jan 15, 2015 · 7 comments · Fixed by #42
Milestone

Comments

@wbolster
Copy link

The summary says it all.

@hynek
Copy link
Owner

hynek commented Jan 15, 2015

PR? 😇

@hynek hynek added this to the 15.0.0 milestone Jan 15, 2015
@wbolster
Copy link
Author

Had a quick look, but doesn't look like there's a test where I can add just one line? Signature is .log(level, event, *args, **kwargs), which is different from the other proxied methods because of the level arg.

@hynek
Copy link
Owner

hynek commented Jan 16, 2015

yeah it’s a special case

@hynek
Copy link
Owner

hynek commented Jan 21, 2015

(fyi, I’m on it)

@wbolster
Copy link
Author

great. i tried and quickly gave up ;)

afaiu the processing chain needs to be called since the parent class can't be used as-is, and the filter_by_level processor also broke because the method name is log, which is not a log level...

@hynek
Copy link
Owner

hynek commented Jan 21, 2015

I believe #42 should fix that, opinions?

@wbolster
Copy link
Author

Yes, opinions, written down in #42. ;)

@hynek hynek closed this as completed in #42 Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants