Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoreKit 2 migration 🥳 #1403

Closed
hyochan opened this issue Jul 3, 2021 Discussed in #1370 · 25 comments
Closed

StoreKit 2 migration 🥳 #1403

hyochan opened this issue Jul 3, 2021 Discussed in #1370 · 25 comments
Assignees
Labels
1️⃣ good first issue Good for newcomers 🙏 help wanted Extra attention is needed 🚽 migration Activities due to changes in framework
Milestone

Comments

@hyochan
Copy link
Owner

hyochan commented Jul 3, 2021

Discussed in #1370

Originally posted by neilco June 9, 2021
There's lots of interesting changes coming in StoreKit 2. Just throwing my hat in the ring early for helping out with adding StoreKit 2 support.

@hyochan hyochan added 1️⃣ good first issue Good for newcomers 🚽 migration Activities due to changes in framework labels Jul 3, 2021
@hyochan
Copy link
Owner Author

hyochan commented Jul 28, 2021

I am currently confused about what we can do with this. Looks like we have nothing to do to change the source code?

Hope someone can give any other insights to this thread.

@neilco Any idea?

@neilco
Copy link
Contributor

neilco commented Jul 28, 2021

@hyochan I would start by comparing the original StoreKit API to the StoreKit 2 API. They are radically different. Also, check out the Meet StoreKit 2 session from this year's WWDC.

@stale
Copy link

stale bot commented Apr 18, 2022

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale label Apr 18, 2022
@nchase
Copy link

nchase commented Apr 20, 2022

Did anything in the 8.0.0 release of react-native-iap move the needle on this issue, or was 8.0.0 just a migration to Swift?

@stale stale bot removed the Stale label Apr 20, 2022
@lukebars
Copy link

lukebars commented Jun 1, 2022

Any news about this migration? Do you need any help?

@hyochan hyochan added this to the Next milestone Jun 1, 2022
@hyochan
Copy link
Owner Author

hyochan commented Jun 1, 2022

@lukebars I have not had a chance to look into this closely. If we can find a starting point that gives us direction, I think it will help us not hesitate to proceed.
I'm currently not sure where to start without deepening it.

@lukebars
Copy link

@hyochan I'm investigating the migration to SK2, got some methods already working. I'll share my findings in a week or so, when whole transition POC will be complete. Seems like we're gonna need to support both, as SK2 supports only iOS 15.0+.

@hyochan
Copy link
Owner Author

hyochan commented Jun 26, 2022

@lukebars Sounds fabulous. Looking forward to it!

@andresesfm
Copy link
Contributor

Any updates on this @lukebars ?

@andresesfm andresesfm added the 🙏 help wanted Extra attention is needed label Jul 25, 2022
@lukebars
Copy link

lukebars commented Aug 2, 2022

Hey @andresesfm, I've managed to migrate most of the methods to SK2, now need to do the listeners and so on. I'll publish the branch is somebody wants to get their hands on it. We also need to think about some kind of architecture to support both, as SK1 and SK2 are quite different.

@andresesfm
Copy link
Contributor

That's great news @lukebars. Yes, please post your branch so we can start looking at it

@andresesfm andresesfm self-assigned this Aug 12, 2022
@andresesfm
Copy link
Contributor

Please follow updates/ collaborate here: #1370

@andresesfm
Copy link
Contributor

I have just published 11.0.0-alpha.1 with the basic implementation of SK2. Please let me know of any issues

@andresesfm
Copy link
Contributor

Published 11.0.0-alpha.6 with backwards compatiblity. No longer need to target iOS 15 in order to use the library. However, in order to use sk2 you'll need to target ios 15.0

@basemanabulsi
Copy link

Hello guys,
How can I help? is there any guidance I can walk through to contribute with you? I am interested to work with you on the features

@andresesfm
Copy link
Contributor

@basemanabulsi take a look at the next branch, that's where I'm merging the Sk2 changes. Help with testing/ documentation would be greatly appreciated. Also need help exposing the new methods to Js. I'm currently working on backward compatibility. Let me know what interests you the most and I can create a ticket with the details

@basemanabulsi
Copy link

@andresesfm Awesome, thank you for the guidance. Currently I am browsing and understanding the code more so I can dig into it.
Also, I am happy to update the documentation

@andresesfm
Copy link
Contributor

@basemanabulsi if you are changing the documentation please do it against the next branch as I'm currently getting it ready for release. Thank you and let me know if any questions

@andresesfm
Copy link
Contributor

Released 11.0.0-rc.1 Including migration guide: https://github.com/dooboolab/react-native-iap/blob/next/docs/docs/migrate_to_11.0.0.md Please let me know if any issues before the actual 11.0.0 release

@andresesfm
Copy link
Contributor

Released 11.0.0-rc.3 with updated migration instructions

@andresesfm
Copy link
Contributor

Released 11.0.0-rc.4 with updated migration instructions. This will be the last RC

@andresesfm
Copy link
Contributor

PR to merge into main: #1985

@emberist
Copy link

Hey @andresesfm, when do you think version 11.0.0 will be released?

@andresesfm
Copy link
Contributor

As soon as we get enough eyes that validate it is stable @emberist. Implementation is complete. The code will be exactly what you'll see in 11.0.0-rc.5 if you want to start integrating and give us feedback, it would be of great help

@andresesfm
Copy link
Contributor

andresesfm commented Sep 26, 2022

11.0.0 has been released. Thank you everybody for your feedback. Going forward please create new tickets if you run into any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ good first issue Good for newcomers 🙏 help wanted Extra attention is needed 🚽 migration Activities due to changes in framework
Projects
None yet
Development

No branches or pull requests

7 participants