Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: POST + not reading the body + keepalive => parser leaks the body to next request #540

Closed
golddranks opened this issue May 20, 2015 · 2 comments

Comments

@golddranks
Copy link

When sending payload from client to Hyper server using POST, but not reading the body when handling the Request, the body is never consumed from the buffered network stream. If the connection stays alive, and the next message is sent, the body of the previous message is going to mess up the following message, like this:

Request Line: Extension("email=pyry.kontio%40drasa.eu&password=supersecretpasswordGET") AbsolutePath("/") Http11

I think we should consume the body after the request has been handled (row 212 of https://github.com/hyperium/hyper/blob/master/src/server/mod.rs ), and after it's clear we'll continue the loop (row 219).

@seanmonstar
Copy link
Member

Looks like #309

@seanmonstar
Copy link
Member

Closing as dupe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants