-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make contract deployments more reliable #413
Comments
Another nice thing would be to specify things like
Though I wonder if this should actually be done at the provider level instead of our abstraction level |
Thinking about gasLimit/estimation, it occurred to me that our provider abstraction isn't super consistent, some configuration we basically push down to the provider that is passed in in the It makes sense why we arrived here (confirmations cannot be supported at the provider level), but should all eip1559/gas pricing/gas limit setting be done at the multiprovider level? |
Hmm interestingly, supposedly ethers-rs should already support automatic 1559 detection ethers-io/ethers.js#1610 |
@nambrot Are you confusing ethers-rs with ethers.js here? |
Sorry I meant ethers js |
Closing this for now, if further improvements should be made, file another ticket |
SDK Deployments are very naive today. They should be:
The text was updated successfully, but these errors were encountered: