Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contract deployments more reliable #413

Closed
nambrot opened this issue May 10, 2022 · 6 comments
Closed

Make contract deployments more reliable #413

nambrot opened this issue May 10, 2022 · 6 comments
Labels

Comments

@nambrot
Copy link
Contributor

nambrot commented May 10, 2022

SDK Deployments are very naive today. They should be:

  • Better about gas pricing (EIP1559, bump gas when spikes happen)
  • More resilient to intermittent RPC issues and errors
  • Resumable
  • Reusable (i.e. use some contracts from a previous deploy)
  • More transparent (i.e. know what is going on for the developer)
@nambrot nambrot moved this to Backlog in Hyperlane Tasks May 10, 2022
@nambrot nambrot moved this from Backlog to Sprint Backlog in Hyperlane Tasks May 10, 2022
This was referenced May 16, 2022
@nambrot
Copy link
Contributor Author

nambrot commented May 18, 2022

Another nice thing would be to specify things like

  • Retries
  • gasLimit buffer
  • Logging/log levels

Though I wonder if this should actually be done at the provider level instead of our abstraction level

@nambrot
Copy link
Contributor Author

nambrot commented May 18, 2022

Thinking about gasLimit/estimation, it occurred to me that our provider abstraction isn't super consistent, some configuration we basically push down to the provider that is passed in in the TransactionConfig/IChainConnection, some we expose at the multiprovider/chain-connection level (supports1599) for example (which uses TransactionConfig/IChainConnection).

It makes sense why we arrived here (confirmations cannot be supported at the provider level), but should all eip1559/gas pricing/gas limit setting be done at the multiprovider level?

@nambrot
Copy link
Contributor Author

nambrot commented May 18, 2022

Hmm interestingly, supposedly ethers-rs should already support automatic 1559 detection ethers-io/ethers.js#1610

@jmrossy
Copy link
Contributor

jmrossy commented May 26, 2022

Hmm interestingly, supposedly ethers-rs should already support automatic 1559 detection

@nambrot Are you confusing ethers-rs with ethers.js here?

@nambrot
Copy link
Contributor Author

nambrot commented May 26, 2022

Sorry I meant ethers js

@nambrot
Copy link
Contributor Author

nambrot commented Jun 22, 2022

Closing this for now, if further improvements should be made, file another ticket

@nambrot nambrot closed this as completed Jun 22, 2022
Repository owner moved this from Sprint Backlog to Done in Hyperlane Tasks Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants