Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): fix type exports in examples/cactus-common-example-server #3632

Open
ruzell22 opened this issue Nov 13, 2024 · 2 comments
Open
Assignees
Labels
bug Something isn't working P3 Priority 3: Medium Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.

Comments

@ruzell22
Copy link
Contributor

Description

Relates to: #3140

Ignore pattern has been added in tools/custom-checks/get-all-tgz-path.ts in PR #3561 for packages that are having error when running the newly added check in custom-checks to validate exported types being correct so that the job will pass for now.

This ticket is created to fix examples/cactus-common-example-server/hyperledger-cactus-common-example-server-*.tgz and delete it in the ignore pattern right after. For more info about the custom-check log, refer to this github action link:
https://github.com/hyperledger-cacti/cacti/actions/runs/11798447068/job/32864671597?pr=3561

and this discussion reply:
#3561 (review)

Related link that can help with regards to the error logs:
https://www.npmjs.com/package/@arethetypeswrong/cli

Acceptance Criteria

  1. ci yarn-custom-checks should pass
  2. remove the ignore pattern for this specific package in tools/custom-checks/get-all-tgz-path.ts
@ruzell22 ruzell22 changed the title ci(github): fix tgz file in examples/cactus-common-example-server ci(github): fix type exports in examples/cactus-common-example-server Nov 13, 2024
@petermetz petermetz added bug Something isn't working Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc. P3 Priority 3: Medium labels Nov 13, 2024
@ruzell22
Copy link
Contributor Author

ruzell22 commented Dec 3, 2024

On hold for now, similar to #3633 , LedgerEvent is being exported in public-api.ts but is not reflecting on .js file when building. More details about the tests made here:
https://github.com/hyperledger-cacti/cacti/pull/3654#issuecomment-2505367464
https://github.com/hyperledger-cacti/cacti/pull/3654#issuecomment-2509561816

@outSH
Copy link
Contributor

outSH commented Dec 3, 2024

@ruzell22 Packages in examples/* are not part of public API and can be modified anytime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3 Priority 3: Medium Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.
Projects
None yet
Development

No branches or pull requests

3 participants