Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core-api): normalize consortium data model #409

Merged
merged 1 commit into from
Jan 5, 2021
Merged

refactor(core-api): normalize consortium data model #409

merged 1 commit into from
Jan 5, 2021

Conversation

petermetz
Copy link
Contributor

How to Review

This PR depends on another PR to ensure that the authors are not blocked in performing their work while waiting for the pull request to get reviewed. Please read the each point of the description below carefully!

  • It is strongly recommended that you review the parent PR first before reviewing this one because once that one (parent PR) is merged, this can be rebased onto the main branch which will literally disappear the additional commits that are shown in this PR but actually belong to the parent PR
  • Before this one can be merged, refactor(core-api): discontinue validator plugin aspect #408 has to be approved and merged first.
  • Reviewing this one can be done as of right now by looking at the changes made specifically by the single commit that this branch commits on top of the branch of the parent branch (parent PR)
  • Feel free to ask @petermetz via any of your preferred communication channels for help if you get stuck using the GitHub UI or any git features during the review.
  • You can use the 'commits' tab of the PR page of GitHub to filter down the diff to a specific commit which allows you to not be bothered by the other commits at all (which belong to the parent PR). To see which commit to filter the diffs down onto, see the section below titled as "commit to be reviewed".

Commit to be reviewed:

Author: Peter Somogyvari <peter.somogyvari@accenture.com>
Date:   Wed Dec 2 17:02:55 2020 -0800

    refactor(core-api): normalize consortium data model

    Resolves #351

    Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Resolves #349

@petermetz petermetz added enhancement New feature or request API_Server labels Dec 3, 2020
@petermetz petermetz force-pushed the refactor/core-api/normalize-consortium-data-model-349 branch from 9ee077d to 509ed53 Compare December 3, 2020 17:16
jonathan-m-hamilton
jonathan-m-hamilton approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz force-pushed the refactor/core-api/normalize-consortium-data-model-349 branch from 509ed53 to 801fa80 Compare December 3, 2020 21:26
@petermetz petermetz mentioned this pull request Dec 4, 2020
Merged
@petermetz petermetz added this to the v0.3.0 milestone Dec 4, 2020
@petermetz petermetz force-pushed the refactor/core-api/normalize-consortium-data-model-349 branch from 801fa80 to f14f200 Compare December 4, 2020 21:49
takeutak
takeutak reviewed Dec 11, 2020
View reviewed changes
Copy link
Contributor

@takeutak takeutak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design of Consortium Plugin depends to the architecture of Cactus, and this is now under the discussion in PR #331, #368. Therefore, please allow me to review this PR after PR #331, #368.

@petermetz
Copy link
Contributor Author

The design of Consortium Plugin depends to the architecture of Cactus, and this is now under the discussion in PR #331, #368. Therefore, please allow me to review this PR after PR #331, #368.

@takeutak Please see my question at
#402 (comment)

@petermetz petermetz force-pushed the refactor/core-api/normalize-consortium-data-model-349 branch 2 times, most recently from 8903806 to 526cd8f Compare December 13, 2020 17:29
@petermetz petermetz force-pushed the refactor/core-api/normalize-consortium-data-model-349 branch 4 times, most recently from 078228d to 0e806ee Compare December 16, 2020 21:48
@takeutak takeutak self-requested a review December 21, 2020 12:32
takeutak
takeutak approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@takeutak takeutak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz
refactor(core-api): normalize consortium data model
7abdde2 
Resolves hyperledger-cacti#351

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the refactor/core-api/normalize-consortium-data-model-349 branch from 0e806ee to 7abdde2 Compare January 4, 2021 23:19
@petermetz petermetz merged commit a78b18d into hyperledger-cacti:master Jan 5, 2021
@petermetz petermetz deleted the refactor/core-api/normalize-consortium-data-model-349 branch January 5, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takeutak takeutak takeutak approved these changes

@jonathan-m-hamilton jonathan-m-hamilton jonathan-m-hamilton approved these changes

@sfuji822 sfuji822 Awaiting requested review from sfuji822

Assignees
No one assigned
Labels
API_Server enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

refactor(core-api): normalize consortium data model
3 participants
@petermetz @jonathan-m-hamilton @takeutak