Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider introducing limit for long queries #3379

Closed
Arjentix opened this issue Apr 14, 2023 · 4 comments
Closed

Consider introducing limit for long queries #3379

Arjentix opened this issue Apr 14, 2023 · 4 comments
Assignees
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@Arjentix
Copy link
Contributor

Arjentix commented Apr 14, 2023

@arndey suggested to intorduce the limit feature, so that there will be a way to limit execution of long queries (i.e. FindAllAssets requires 3 nested loops).

@appetrosyan , suggested to use lazy evaluation, wsv clonning and paggination to implement this.

@Arjentix Arjentix added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Apr 14, 2023
@Arjentix
Copy link
Contributor Author

According to @arndey , 50k assets search takes 10s on local machine

@mversic
Copy link
Contributor

mversic commented Apr 18, 2023

possible duplicate of #3347

@appetrosyan
Copy link
Contributor

One potential solution is to introduce re-entrant pagination and default to returning a reasonably paginated lazily evaluated result.

@Mingela
Copy link
Contributor

Mingela commented May 23, 2023

Agree to solve the issue implementing a pagination and close this one in favor of that one

@mversic mversic closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

4 participants