Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract TODO's #259

Open
ggwpez opened this issue Nov 15, 2021 · 0 comments
Open

Extract TODO's #259

ggwpez opened this issue Nov 15, 2021 · 0 comments
Labels
refactor No logic but only implementation changes.

Comments

@ggwpez
Copy link
Contributor

ggwpez commented Nov 15, 2021

Location

Many *.go files.

Problem

TODO/BUG/FIXME should be removed from the code, the new linter is also not happy with them.

Proposal

We collect them here and triage so that i can remove them from the code.

client/sync.go // TODO cancel ongoing protocol, like Update
client/restore.go // TODO
client/update.go // TODO this is insecure after we sent our signature.
client/update.go // TODO how to handle invalid updates? Just drop and ignore them?
client/update.go // TODO how to handle invalid updates? Just drop and ignore them?
client/update.go // TODO this is insecure after we sent our signature.
wire/relay_test.go TODO waiting for mocked Endpoint
channel/persistence/statemachine_test.go // TODO After #316 (custom random gens) this test can be greatly improved.
watcher/local/watcher.go // TODO Should the subscription be closed with an error ?

@ggwpez ggwpez added the refactor No logic but only implementation changes. label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor No logic but only implementation changes.
Projects
None yet
Development

No branches or pull requests

1 participant