Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move VerifySignature from wallet.Backend to wallet.Sig #294

Open
manoranjith opened this issue Dec 14, 2021 · 1 comment
Open

Move VerifySignature from wallet.Backend to wallet.Sig #294

manoranjith opened this issue Dec 14, 2021 · 1 comment

Comments

@manoranjith
Copy link
Contributor

Location

wallet, ethereum/wallet, sim/wallet

Problem

Previously, VerifySignature function is defined on the wallet backend. This looked fine, because until recently, wallet.Sig was defined as a byte array. But, now it has been redefined as an interface with each wallet implementation implementing the wallet.Sig interface (see #292). Now, it looks odd to use the wallet.Backend.VerifySignature method when Sig itself is defined as a separate type.

Proposal

Move the VerifySignature method from wallet.Backend to wallet.Sig interface.
@manoranjith
Copy link
Contributor Author

@matthiasgeihs

@manoranjith manoranjith mentioned this issue Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move verify function from wallet.Backend to wallet.Sig boschresearch/go-perun
1 participant
@manoranjith