Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve race detection in endpoint registry #386

Open
RmbRT opened this issue Feb 28, 2023 · 0 comments
Open

Improve race detection in endpoint registry #386

RmbRT opened this issue Feb 28, 2023 · 0 comments
Labels
bug Something isn't working enhancement Improvement of an existing feature

Comments

@RmbRT
Copy link
Contributor

RmbRT commented Feb 28, 2023

Locationwire/net.EndpointRegistry
Problem Replacing a connection before it timed out on the other end will trigger the race detector, even if there is no race.
Proposal For each Endpoint, remember the time it was opened. During fullEndpoint.replace(), if !dialed (i.e., we have an incoming connection) and the previous endpoint is older than 5 seconds, do not perform the race check, and simply discard the old connection.

@RmbRT RmbRT added bug Something isn't working enhancement Improvement of an existing feature labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant