From a2dbb8272c47f537261819da565a948902e1a514 Mon Sep 17 00:00:00 2001
From: Suyash Nayan <89125422+7suyash7@users.noreply.github.com>
Date: Wed, 25 Oct 2023 07:35:00 +0530
Subject: [PATCH] Optimize GetPooledTransactionsFromPeerTask with HashSet
 (#6071)

Switch from using a List to a HashSet for transaction hashes in GetPooledTransactionsFromPeerTask to improve performance.

Signed-off-by: Suyash Nayan <suyashnyn1@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
---
 .../task/GetPooledTransactionsFromPeerTask.java        | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/task/GetPooledTransactionsFromPeerTask.java b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/task/GetPooledTransactionsFromPeerTask.java
index ca3c90af5f1..06151ba68c8 100644
--- a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/task/GetPooledTransactionsFromPeerTask.java
+++ b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/task/GetPooledTransactionsFromPeerTask.java
@@ -27,8 +27,10 @@
 import org.hyperledger.besu.plugin.services.MetricsSystem;
 
 import java.util.ArrayList;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Optional;
+import java.util.Set;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -38,12 +40,12 @@ public class GetPooledTransactionsFromPeerTask extends AbstractPeerRequestTask<L
   private static final Logger LOG =
       LoggerFactory.getLogger(GetPooledTransactionsFromPeerTask.class);
 
-  private final List<Hash> hashes;
+  private final Set<Hash> hashes;
 
   private GetPooledTransactionsFromPeerTask(
       final EthContext ethContext, final List<Hash> hashes, final MetricsSystem metricsSystem) {
     super(ethContext, EthPV65.GET_POOLED_TRANSACTIONS, metricsSystem);
-    this.hashes = List.copyOf(hashes);
+    this.hashes = new HashSet<>(hashes);
   }
 
   public static GetPooledTransactionsFromPeerTask forHashes(
@@ -51,7 +53,7 @@ public static GetPooledTransactionsFromPeerTask forHashes(
     return new GetPooledTransactionsFromPeerTask(ethContext, hashes, metricsSystem);
   }
 
-  public List<Hash> getTransactionHashes() {
+  public Set<Hash> getTransactionHashes() {
     return hashes;
   }
 
@@ -60,7 +62,7 @@ protected PendingPeerRequest sendRequest() {
     return sendRequestToPeer(
         peer -> {
           LOG.debug("Requesting {} transaction pool entries from peer {}.", hashes.size(), peer);
-          return peer.getPooledTransactions(hashes);
+          return peer.getPooledTransactions(new ArrayList<>(hashes));
         },
         0);
   }