Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging when RPC parameters are missing or empty #4326

Closed
jflo opened this issue Aug 29, 2022 · 0 comments · Fixed by #4510
Closed

Improve logging when RPC parameters are missing or empty #4326

jflo opened this issue Aug 29, 2022 · 0 comments · Fixed by #4510
Assignees
Labels
logging RPC snack Smaller coding task - less than a day for an experienced dev TeamRevenant GH issues worked on by Revenant Team

Comments

@jflo
Copy link
Contributor

jflo commented Aug 29, 2022

Get a bunch of these, not really important but would be better to handle this gracefully (bloomfilter = nil)

org.hyperledger.besu.ethereum.api.jsonrpc.internal.exception.InvalidJsonRpcParameters: Invalid json rpc parameter at index 0
	at org.hyperledger.besu.ethereum.api.jsonrpc.internal.parameters.JsonRpcParameter.optional(JsonRpcParameter.java:77)
	at org.hyperledger.besu.ethereum.api.jsonrpc.internal.parameters.JsonRpcParameter.required(JsonRpcParameter.java:42)
	at org.hyperledger.besu.ethereum.api.jsonrpc.internal.JsonRpcRequest.getRequiredParameter(JsonRpcRequest.java:133)
	at org.hyperledger.besu.ethereum.api.jsonrpc.internal.JsonRpcRequestContext.getRequiredParameter(JsonRpcRequestContext.java:64)```

and also

```2022-08-25 21:23:02.473+02:00 | vert.x-eventloop-thread-30 | ERROR | ExecutionEngineJsonRpcMethod | failed to exec consensus method engine_forkchoiceUpdatedV1
org.hyperledger.besu.ethereum.api.jsonrpc.internal.exception.InvalidJsonRpcParameters: Invalid json rpc parameter at index 1
	at org.hyperledger.besu.ethereum.api.jsonrpc.internal.parameters.JsonRpcParameter.optional(JsonRpcParameter.java:77)
	at org.hyperledger.besu.ethereum.api.jsonrpc.internal.JsonRpcRequest.getOptionalParameter(JsonRpcRequest.java:137)
	at org.hyperledger.besu.ethereum.api.jsonrpc.internal.JsonRpcRequestContext.getOptionalParameter(JsonRpcRequestContext.java:68)```



### Acceptance Criteria
* Logging it more clear and helpful when an RPC call is malformed


@jflo jflo added the logging label Aug 29, 2022
@non-fungible-nelson non-fungible-nelson added the snack Smaller coding task - less than a day for an experienced dev label Aug 31, 2022
@jflo jflo self-assigned this Aug 31, 2022
@macfarla macfarla added the 22.7.2 label Sep 4, 2022
@jflo jflo removed their assignment Sep 6, 2022
@iamhsk iamhsk added the TeamRevenant GH issues worked on by Revenant Team label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging RPC snack Smaller coding task - less than a day for an experienced dev TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants