Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clique createemptyblock set to false, should allow to sync even if there are empty blocks #6290

Closed
fab-10 opened this issue Dec 13, 2023 · 1 comment · Fixed by #6608
Closed
Assignees
Labels
consensus syncing TeamChupa GH issues worked on by Chupacabara Team TeamGroot GH issues worked on by Groot Team

Comments

@fab-10
Copy link
Contributor

fab-10 commented Dec 13, 2023

Found that the createemptyblocks option, introduced in #6082, prevents syncing a network that had some empty blocks at the beginning, that scenario could happen if a network was created without this option (or with it set to true) and then changed to false.

The validation should only apply when the node is creating a block, but not when the node is syncing/importing existing blocks.

@jframe
Copy link
Contributor

jframe commented Dec 14, 2023

That is the expected behaviour, the value for createemptyblocks must be the same and was documented with that warning https://besu.hyperledger.org/development/private-networks/how-to/configure/consensus/clique#skip-empty-blocks.

If we don't validate existing blocks then it would be possible for nodes to have a different value for createemptyblocks and we could have a network split. I guess could just validate newly imported blocks though including those that are created and imported that might be ok.

Is it necessary to change from having no empty blocks to having empty blocks? A nicer approach rather than removing the header validation would be add a transition for this.

@non-fungible-nelson non-fungible-nelson added TeamGroot GH issues worked on by Groot Team consensus syncing TeamChupa GH issues worked on by Chupacabara Team labels Dec 18, 2023
@siladu siladu self-assigned this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus syncing TeamChupa GH issues worked on by Chupacabara Team TeamGroot GH issues worked on by Groot Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants