Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias --fast-sync-min-peers to --sync-min-peers #6327

Closed
non-fungible-nelson opened this issue Dec 21, 2023 · 0 comments · Fixed by #6373
Closed

Alias --fast-sync-min-peers to --sync-min-peers #6327

non-fungible-nelson opened this issue Dec 21, 2023 · 0 comments · Fixed by #6373
Assignees
@macfarla
Labels
logging mainnet non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT snack Smaller coding task - less than a day for an experienced dev syncing TeamChupa GH issues worked on by Chupacabara Team TeamRevenant GH issues worked on by Revenant Team ux

Comments

@non-fungible-nelson
Copy link
Contributor

non-fungible-nelson commented Dec 21, 2023 •
edited
Loading

Description

The flag --fast-sync-min-peers actually impacts SNAP and CHECKPOINT sync on non-POS networks. This ticket should remedy that by aliasing it with a new --sync-min-peers. We also need to update the documentation to reflect this fact. image.png
Something like "This flag only impacts non-Proof of Stake networks."

One other thought for --sync-min-peers. FULL sync could be changed to tolerate it and just give a warning, instead of preventing node startup. Other options seem to be treated that way and that slightly more permissive approach is can be helpful in certain circumstances.
@non-fungible-nelson non-fungible-nelson added TeamRevenant GH issues worked on by Revenant Team mainnet logging syncing TeamChupa GH issues worked on by Chupacabara Team ux non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT labels Dec 21, 2023
@non-fungible-nelson non-fungible-nelson mentioned this issue Dec 21, 2023
Closed
@macfarla macfarla added the snack Smaller coding task - less than a day for an experienced dev label Jan 8, 2024
@macfarla macfarla self-assigned this Jan 8, 2024
This was referenced Jan 9, 2024
Merged
Merged
@macfarla macfarla closed this as completed Jan 9, 2024
@macfarla macfarla mentioned this issue Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macfarla macfarla

Labels
logging mainnet non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT snack Smaller coding task - less than a day for an experienced dev syncing TeamChupa GH issues worked on by Chupacabara Team TeamRevenant GH issues worked on by Revenant Team ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

full sync - don't fail startup if sync-min-peers specified macfarla/besu
2 participants
@macfarla @non-fungible-nelson