Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Dagger to pass around the MiningParameters #6736

Open
macfarla opened this issue Mar 14, 2024 · 1 comment
Open

use Dagger to pass around the MiningParameters #6736

macfarla opened this issue Mar 14, 2024 · 1 comment
Assignees
@jflo
Labels
dev experience The build system, things that enable easier development etc.

Comments

@macfarla
Copy link
Contributor

Refactor the changes introduced by this PR to use Dagger to pass around the MiningParameters - it's a good candidate for dependency injection

#6562
@macfarla macfarla added the dev experience The build system, things that enable easier development etc. label Mar 14, 2024
@jflo jflo self-assigned this Apr 4, 2024
@jflo
Copy link
Contributor

jflo commented Jul 17, 2024

MainnetProtocolSpecs.java looks like the thing that actually uses MiningParameters when it is setting up its fee market.

Could be an opportunity here to implement both this and solve #7326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jflo jflo

Labels
dev experience The build system, things that enable easier development etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jflo @macfarla