Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use authority() instead of deprecated host() method in "allow list" #6878

Closed
usmansaleem opened this issue Apr 3, 2024 · 0 comments · Fixed by #6879
Closed

Use authority() instead of deprecated host() method in "allow list" #6878

usmansaleem opened this issue Apr 3, 2024 · 0 comments · Fixed by #6879
Assignees

Comments

@usmansaleem
Copy link
Member

Description

Besu code uses RoutingContext.request.host() to determine the host header which is then used to determine the "host allow list" logic. This method has been deprecated in Vert.x. It should be replaced with RoutingContext.request.authority(). This would allow a more cleaner logic and future proofing the code.

Acceptance Criteria

Fix at following locations:
org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpService.java:224
org/hyperledger/besu/ethereum/api/jsonrpc/EngineJsonRpcService.java:622
org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpService.java:513
org/hyperledger/besu/ethereum/api/jsonrpc/websocket/WebSocketService.java:297
org/hyperledger/besu/metrics/prometheus/MetricsHttpService.java:161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant