Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainnet nodes occasionally report Classic block heights #1751

Closed
shemnon opened this issue Jan 5, 2021 · 0 comments
Closed

Mainnet nodes occasionally report Classic block heights #1751

shemnon opened this issue Jan 5, 2021 · 0 comments
Labels
bug Something isn't working P4 Low (ex: Node doesn't start up when the configuration file has unexpected "end-of-line" character)

Comments

@shemnon
Copy link
Contributor

shemnon commented Jan 5, 2021

Occasionally the prometheus metrics report the Ethereum Classic chain height as the Mainnet chain height.

Screen Shot 2021-01-05 at 3 08 45 PM

What I think is going on is that there is a short period of time between when we handshake a peer and consider it a full peer when we ask some things of the node, such as what their dao block hash is. During that period the peer is still in the collections that are used to (a) query height and (b) query total node count. To fix this we need to interrogate the node prior to "full peer admission" whatever that looks like.

@timbeiko timbeiko added bug Something isn't working P4 Low (ex: Node doesn't start up when the configuration file has unexpected "end-of-line" character) labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P4 Low (ex: Node doesn't start up when the configuration file has unexpected "end-of-line" character)
Projects
None yet
Development

No branches or pull requests

2 participants