From 5ca0716d10502ffc04e7b479fa47ab3c38d85f21 Mon Sep 17 00:00:00 2001 From: Jiri Peinlich Date: Thu, 25 Aug 2022 12:31:03 +0100 Subject: [PATCH] Reducing verbosity during BWS errors Stacktrace can be retrieved by increasing the log level Signed-off-by: Jiri Peinlich --- .../backwardsync/BackwardSyncContext.java | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncContext.java b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncContext.java index 25a6a9582b9..78576b105d3 100644 --- a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncContext.java +++ b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncContext.java @@ -202,24 +202,24 @@ protected void processException(final Throwable throwable) { backwardSyncException -> { if (backwardSyncException.shouldRestart()) { LOG.info( - "Backward sync failed ({}). Current Peers: {}. Retrying in " - + millisBetweenRetries - + " milliseconds...", - backwardSyncException.getMessage(), - ethContext.getEthPeers().peerCount()); - return; + "Backward sync failed ({}). Current Peers: {}. Retrying in {} milliseconds...", + throwable.getMessage(), + ethContext.getEthPeers().peerCount(), + millisBetweenRetries); } else { debugLambda( LOG, "Not recoverable backward sync exception {}", throwable::getMessage); throw backwardSyncException; } }, - () -> - LOG.warn( - "There was an uncaught exception during Backwards Sync. Retrying in " - + millisBetweenRetries - + " milliseconds...", - throwable)); + () -> { + LOG.warn( + "Backward sync failed ({}). Current Peers: {}. Retrying in {} milliseconds...", + throwable.getMessage(), + ethContext.getEthPeers().peerCount(), + millisBetweenRetries); + LOG.debug("Exception details:", throwable); + }); } private Optional extractBackwardSyncException(final Throwable throwable) {