Skip to content

Commit

Permalink
fix(deps): missing uuid from plugins #529
Browse files Browse the repository at this point in the history
Adds the missing dependency "uuid" to the packages where applicable.

Also updates the import syntax in
packages/cactus-plugin-consortium-manual/src/main/typescript/consortium/get-node-jws-endpoint-v1.ts
which appears to make a difference?

Fixes #529

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
  • Loading branch information
petermetz committed Feb 7, 2021
1 parent febc06f commit 04ea8bb
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 6 deletions.
11 changes: 11 additions & 0 deletions packages/cactus-plugin-consortium-manual/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions packages/cactus-plugin-consortium-manual/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,16 @@
"json-stable-stringify": "1.0.1",
"lodash": "4.17.19",
"secp256k1": "4.0.1",
"typescript-optional": "2.0.1"
"typescript-optional": "2.0.1",
"uuid": "8.3.2"
},
"devDependencies": {
"@types/express": "4.17.8",
"@types/joi": "14.3.4",
"@types/json-stable-stringify": "1.0.32",
"@types/lodash": "4.14.158",
"@types/multer": "1.4.3",
"@types/secp256k1": "4.0.1"
"@types/secp256k1": "4.0.1",
"@types/uuid": "8.3.0"
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import uuid from "uuid";
import { v4 as uuidv4 } from "uuid";
import { Express, Request, Response } from "express";
import { JWS, JWK } from "jose";
import jsonStableStringify from "json-stable-stringify";
Expand Down Expand Up @@ -100,7 +100,7 @@ export class GetNodeJwsEndpoint implements IWebServiceEndpoint {
const payloadJson = jsonStableStringify(payloadObject);
const _protected = {
iat: Date.now(),
jti: uuid.v4(),
jti: uuidv4(),
iss: "Hyperledger Cactus",
};
// TODO: double check if this casting is safe (it is supposed to be)
Expand Down
11 changes: 11 additions & 0 deletions packages/cactus-plugin-keychain-memory/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions packages/cactus-plugin-keychain-memory/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,11 @@
"@hyperledger/cactus-common": "0.3.0",
"@hyperledger/cactus-core-api": "0.3.0",
"joi": "14.3.1",
"typescript-optional": "2.0.1"
"typescript-optional": "2.0.1",
"uuid": "8.3.2"
},
"devDependencies": {
"@types/joi": "14.3.4"
"@types/joi": "14.3.4",
"@types/uuid": "8.3.0"
}
}

0 comments on commit 04ea8bb

Please sign in to comment.