Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keychain-vault): Fixing the incomplete endpoint methods #676

Closed
jagpreetsinghsasan opened this issue Mar 17, 2021 · 1 comment · Fixed by #1109
Closed

feat(keychain-vault): Fixing the incomplete endpoint methods #676

jagpreetsinghsasan opened this issue Mar 17, 2021 · 1 comment · Fixed by #1109
Labels
Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.

Comments

@jagpreetsinghsasan
Copy link
Contributor

jagpreetsinghsasan commented Mar 17, 2021 •
edited
Loading

Description

As a developer, I want to fix the following methods, enable them in installWebServices() method and fix the skipped test cases for the same
GetKeychainEntryEndpointV1
SetKeychainEntryEndpointV1

These files specifically
packages/cactus-plugin-keychain-vault/src/main/typescript/web-services/set-keychain-entry-endpoint-v1.ts (getExpressRequestHandler method)
packages/cactus-plugin-keychain-vault/src/main/typescript/web-services/get-keychain-entry-endpoint-v1.ts (getExpressRequestHandler method)
packages/cactus-plugin-keychain-vault/src/main/typescript/plugin-keychain-vault.ts (installWebServices method)
packages/cactus-plugin-keychain-vault/src/test/typescript/integration/plugin-keychain-vault.test.ts (skipped test cases)

Acceptance Criteria

  1. The above endpoint methods should have the methods fixed.
  2. The skipped test cases should be working
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Mar 17, 2021
Merged
@petermetz petermetz added the Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves. label Mar 22, 2021
@petermetz
Copy link
Contributor

@jagpreetsinghsasan Was the linked PR also resolving this issue or is there more to this one that still needs work? Just double checking if we should close the issue or not.

petermetz added a commit to petermetz/cacti that referenced this issue Jul 3, 2021
@petermetz
feat(keychain-vault): add the missing endpoint classes hyperledger-ca…
852ac33 
…cti#676

1. Adds the has/delete endpoints (which were missing completely)
2. Adds the get/set endpoints which were partially already implemented.
3. Moves the express dependency to be a dev dependency since we only
use the types (e.g. only needed at compile time, not at runtime)
4. Adds specific test cases to the API client verifying the
get/set/has/delete endpoints
5. Renames the getKeychainEntry and setKeychainEntry operationIDs
to have a V1 suffix.

Fixes hyperledger-cacti#676

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Jul 3, 2021
Merged
petermetz added a commit that referenced this issue Jul 7, 2021
@petermetz
feat(keychain-vault): add the missing endpoint classes #676
341cffc 
1. Adds the has/delete endpoints (which were missing completely)
2. Adds the get/set endpoints which were partially already implemented.
3. Moves the express dependency to be a dev dependency since we only
use the types (e.g. only needed at compile time, not at runtime)
4. Adds specific test cases to the API client verifying the
get/set/has/delete endpoints
5. Renames the getKeychainEntry and setKeychainEntry operationIDs
to have a V1 suffix.

Fixes #676

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
izuru0 pushed a commit to izuru0/cactus that referenced this issue Jul 12, 2021
@petermetz @izuru0
feat(keychain-vault): add the missing endpoint classes hyperledger-ca…
3d37f24 
…cti#676

1. Adds the has/delete endpoints (which were missing completely)
2. Adds the get/set endpoints which were partially already implemented.
3. Moves the express dependency to be a dev dependency since we only
use the types (e.g. only needed at compile time, not at runtime)
4. Adds specific test cases to the API client verifying the
get/set/has/delete endpoints
5. Renames the getKeychainEntry and setKeychainEntry operationIDs
to have a V1 suffix.

Fixes hyperledger-cacti#676

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@petermetz @RafaelAPB
feat(keychain-vault): add the missing endpoint classes hyperledger-ca…
e4f83c6 
…cti#676

1. Adds the has/delete endpoints (which were missing completely)
2. Adds the get/set endpoints which were partially already implemented.
3. Moves the express dependency to be a dev dependency since we only
use the types (e.g. only needed at compile time, not at runtime)
4. Adds specific test cases to the API client verifying the
get/set/has/delete endpoints
5. Renames the getKeychainEntry and setKeychainEntry operationIDs
to have a V1 suffix.

Fixes hyperledger-cacti#676

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(keychain-vault): add the missing endpoint classes #676 petermetz/cacti
2 participants
@petermetz @jagpreetsinghsasan