Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test-tooling): containers#pruneDockerResources() observability #694

Closed
petermetz opened this issue Mar 20, 2021 · 1 comment · Fixed by #695
Closed

feat(test-tooling): containers#pruneDockerResources() observability #694

petermetz opened this issue Mar 20, 2021 · 1 comment · Fixed by #695
Assignees
@petermetz
Labels
dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is.

Comments

@petermetz
Copy link
Contributor

Description

As a contributor I want to have a way to see what is the outcome of the docker resources pruning so that it is easier for me to debug infrastructure/hardware related CI failures that I encounter.

A good example of such issue is when the GitHub CI Action started failing because the disk was full with docker images that we created in the test cases.
It is particularly hard to debug these failures because the test runner will show a particular test failing and that failure of that test case will not be reproducible on any other machine unless that machine also has the disk full issue.

Acceptance Criteria

  1. The pruning method can log it's own results for itself via a log level parameter
  2. The pruning method also returns the outcome of the pruning process so that callers can either log that for themselves or pass it further up to their callers when applicable.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @jagpreetsinghsasan
@petermetz petermetz added dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. labels Mar 20, 2021
@petermetz petermetz self-assigned this Mar 20, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Mar 20, 2021
@petermetz
feat(test-tooling): pruneDockerResources() observability hyperledger-…
0176f43 
…cacti#694

Primary change
-----------------------

Adds request and response definitions to
the pruneDockerResources() method to
allow callers to control the log levels
and also to get a complete report of the
pruning processes' outcome from the
returned object instead of just returning
with `void`.

Miscellaneous changes
----------------------------------

Significantly improved the documentation
for the utility method in question.

Fixes hyperledger-cacti#694

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
This was referenced Mar 20, 2021
Merged
Closed
petermetz added a commit to petermetz/cacti that referenced this issue Mar 22, 2021
@petermetz
feat(test-tooling): pruneDockerResources() observability hyperledger-…
39bad1a 
…cacti#694

Primary change
-----------------------

Adds request and response definitions to
the pruneDockerResources() method to
allow callers to control the log levels
and also to get a complete report of the
pruning processes' outcome from the
returned object instead of just returning
with `void`.

Miscellaneous changes
----------------------------------

Significantly improved the documentation
for the utility method in question.

Fixes hyperledger-cacti#694

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@kikoncuo
Copy link
Contributor

Is this for local tests or github's?

petermetz added a commit that referenced this issue Mar 23, 2021
@petermetz
feat(test-tooling): pruneDockerResources() observability #694
d92760f 
Primary change
-----------------------

Adds request and response definitions to
the pruneDockerResources() method to
allow callers to control the log levels
and also to get a complete report of the
pruning processes' outcome from the
returned object instead of just returning
with `void`.

Miscellaneous changes
----------------------------------

Significantly improved the documentation
for the utility method in question.

Fixes #694

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam pushed a commit to kikoncuo/cactus that referenced this issue Apr 8, 2021
@petermetz
feat(test-tooling): pruneDockerResources() observability hyperledger-…
ec92212 
…cacti#694

Primary change
-----------------------

Adds request and response definitions to
the pruneDockerResources() method to
allow callers to control the log levels
and also to get a complete report of the
pruning processes' outcome from the
returned object instead of just returning
with `void`.

Miscellaneous changes
----------------------------------

Significantly improved the documentation
for the utility method in question.

Fixes hyperledger-cacti#694

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(test-tooling): pruneDockerResources() observability #694 petermetz/cacti
2 participants
@petermetz @kikoncuo