feat(core-api): decouple web service install & registration #771
Assignees
Labels
API_Server
Core_API
Changes related to the Core API Package
duplicate
This issue or pull request already exists
enhancement
New feature or request
Significant_Change
Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule.
Comments
petermetz
added
API_Server
Core_API
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Apr 7, 2021
…er-cacti#771 Primary change: ============== Divide the endpoint installation method into two smaller ones where the first one only instantiates the endpoints and the other one "registers" them as-in it hooks the endpoint up onto the ExpressJS web app object so that it will actually be responded to as HTTP requests come in. Why though? We'll need this for the authorization MVP which will need to be able to introspect the endpoints **prior** to them getting registered so that it can determine authz specific parameters like "is this endpoint secured or non-secure?" or what scopes are necessary for this endpoint? Etc. Additional changes: ================== Everything else that was needed to make the project compile again and the tests passnig (which is a lot because this is a very central, heavily used interface that we just modified). Fixes hyperledger-cacti#771 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
kikoncuo
pushed a commit
that referenced
this issue
Apr 8, 2021
Primary change: ============== Divide the endpoint installation method into two smaller ones where the first one only instantiates the endpoints and the other one "registers" them as-in it hooks the endpoint up onto the ExpressJS web app object so that it will actually be responded to as HTTP requests come in. Why though? We'll need this for the authorization MVP which will need to be able to introspect the endpoints **prior** to them getting registered so that it can determine authz specific parameters like "is this endpoint secured or non-secure?" or what scopes are necessary for this endpoint? Etc. Additional changes: ================== Everything else that was needed to make the project compile again and the tests passnig (which is a lot because this is a very central, heavily used interface that we just modified). Fixes #771 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
As a contributor to the API server I want to have the option to retrieve the web service endpoint instances prior to registering them onto ExpressJS so that I can implement custom behavior/features in the API server that depend on being able to hook into the Express application object first (e.g. before the endpoints hook themselves up at registration time).
This came up during the development of the authorization MVP which needs exactly this to be able to handle endpoints that want to declare themselves non-secure (e.g. accessible anonymously over the internet)
Acceptance Criteria
cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @jagpreetsinghsasan
The text was updated successfully, but these errors were encountered: