Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test-tooling): add OpenEthereumTestLedger #851

Closed
petermetz opened this issue Apr 23, 2021 · 0 comments · Fixed by #854
Closed

feat(test-tooling): add OpenEthereumTestLedger #851

petermetz opened this issue Apr 23, 2021 · 0 comments · Fixed by #854
Assignees
@petermetz
Labels
Developer_Experience enhancement New feature or request Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus

Comments

@petermetz
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Need an xdai test ledger class so we can test the new xdai connector that's dropping soon.

Describe the solution you'd like

Same as with the rest of the connector's test ledgers, a class that manages a container under the hood so that we can write end to end tests for the connector..

Describe alternatives you've considered

None, I'm pretty sure we need this.

Additional context

This is needed for the carbon accounting app #540 because I realized after the fact that they are not on the main net but xdai instead (makes a lot of sense, tx fees are crazy on the main net).

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @jagpreetsinghsasan @arnab-roy
@petermetz petermetz self-assigned this Apr 23, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
feat(test-tooling): add OpenEthereumTestLedger
df1b1ab 
Fixes hyperledger-cacti#851

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz added the Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus label Apr 23, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
feat(test-tooling): add OpenEthereumTestLedger
8d5844f 
We did not need to roll our own contanier image for this
so the only thing new here is the class in the test tooling
package that makes it convenient to write test cases against
OpenEthereum. The container image used by the class behind
the scenes is just the stock OpenEthereum image from DockerHub.

Fixes hyperledger-cacti#851

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
feat(test-tooling): add OpenEthereumTestLedger hyperledger-cacti#851
7876bd3 
We did not need to roll our own contanier image for this
so the only thing new here is the class in the test tooling
package that makes it convenient to write test cases against
OpenEthereum. The container image used by the class behind
the scenes is just the stock OpenEthereum image from DockerHub.

Fixes hyperledger-cacti#851

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
feat(test-tooling): add OpenEthereumTestLedger hyperledger-cacti#851
f998970 
We did not need to roll our own contanier image for this
so the only thing new here is the class in the test tooling
package that makes it convenient to write test cases against
OpenEthereum. The container image used by the class behind
the scenes is just the stock OpenEthereum image from DockerHub.

Fixes hyperledger-cacti#851

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Apr 23, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
feat(test-tooling): add OpenEthereumTestLedger hyperledger-cacti#851
f12f184 
We did not need to roll our own contanier image for this
so the only thing new here is the class in the test tooling
package that makes it convenient to write test cases against
OpenEthereum. The container image used by the class behind
the scenes is just the stock OpenEthereum image from DockerHub.

Fixes hyperledger-cacti#851

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Apr 23, 2021
@petermetz
feat(test-tooling): add OpenEthereumTestLedger hyperledger-cacti#851
37b757c 
We did not need to roll our own contanier image for this
so the only thing new here is the class in the test tooling
package that makes it convenient to write test cases against
OpenEthereum. The container image used by the class behind
the scenes is just the stock OpenEthereum image from DockerHub.

Fixes hyperledger-cacti#851

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Apr 29, 2021
@petermetz
feat(test-tooling): add OpenEthereumTestLedger #851
9ca1f68 
We did not need to roll our own contanier image for this
so the only thing new here is the class in the test tooling
package that makes it convenient to write test cases against
OpenEthereum. The container image used by the class behind
the scenes is just the stock OpenEthereum image from DockerHub.

Fixes #851

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Developer_Experience enhancement New feature or request Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(test-tooling): add OpenEthereumTestLedger #851 petermetz/cacti
1 participant
@petermetz