Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate error message makes it difficult to determine code location #271

Closed
davidkel opened this issue Oct 28, 2021 · 1 comment · Fixed by hyperledger/fabric#3007
Closed
Assignees

Comments

@davidkel
Copy link
Contributor

There are 2 identical error messages in the code making it difficult to work out which code path occurred.

		if firstEndorser == nil || firstResponse == nil {
			return nil, rpcError(codes.Aborted, "failed to endorse transaction, see attached details for more info", errDetails...)
		}
	if endorsements == nil {
		return nil, rpcError(codes.Aborted, "failed to endorse transaction, see attached details for more info", errorDetails...)
	}

in api.go

Would be good to make these distinguishable or have error log messages in the peer so that you have something in the peer logs to indicate the code path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants