FAB-1053 remove generateNounce() from CryptoSuite API

this is not part of the BCCSP API design and is internal to the encryption algorithm Change-Id: I3511ab55efdc3b4fb1afbe1d47b2aa4097e0d46c Signed-off-by: Jim Zhang <jzhang@us.ibm.com>
hyperledger · Nov 9, 2016 · 013c1a2 · 013c1a2
1 parent 74aaa9a
commit 013c1a2
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 25 deletions.
diff --git a/lib/Member.js b/lib/Member.js
@@ -237,8 +237,6 @@ var Member = class {
 						function(enrollment) {
 
 							self._enrollment = enrollment;
-							// Generate queryStateKey
-							self._enrollment.queryStateKey = self._chain.cryptoPrimitives.generateNonce();
 
 							// Save state
 							return self.saveState()

diff --git a/lib/api.js b/lib/api.js
@@ -115,14 +115,6 @@ module.exports.CryptoSuite = class {
 	 */
 	setHashAlgorithm(hashAlgorithm) {}
 
-	/**
-	 * Generate a nonce to use as one-time state key. Size of the nonce
-	 * is determined by the crypto suite implementation
-	 *
-	 * @returns {byte[]} the random number
-	 */
-	generateNonce() {}
-
 	/**
 	 * Generate asymmetric key pair
 	 *

diff --git a/lib/impl/CryptoSuite_ECDSA_SHA.js b/lib/impl/CryptoSuite_ECDSA_SHA.js
@@ -133,10 +133,6 @@ var CryptoSuite_ECDSA_SHA = class extends api.CryptoSuite {
 		this._initialize();
 	}
 
-	generateNonce() {
-		return crypto.randomBytes(NonceSize);
-	}
-
 	generateKeyPair() {
 		return KEYUTIL.generateKeypair('EC', this._curveName);
 	}

diff --git a/test/unit/headless-tests.js b/test/unit/headless-tests.js
@@ -924,17 +924,6 @@ test('\n\n ** CryptoSuite_ECDSA_SHA - function tests', function(t) {
 		'CryptoSuite_ECDSA_SHA function tests: setHashAlgorithm("SHA5") should throw Illegal Hash function family'
 	);
 
-	var nonce1 = cryptoUtils.generateNonce();
-	if (t.equal(24, nonce1.length,
-		'CryptoSuite_ECDSA_SHA function tests: generateNonce length'));
-
-	var nonce2 = cryptoUtils.generateNonce();
-	var nonce3 = cryptoUtils.generateNonce();
-	if (nonce1 != nonce2 && nonce2 != nonce3)
-		t.pass('CryptoSuite_ECDSA_SHA function tests: verify generateNonce buffers are different');
-	else
-		t.fail('CryptoSuite_ECDSA_SHA function tests: verify generateNonce buffers are different');
-
 	t.throws(
 		function() {
 			cryptoUtils.setHashAlgorithm('SHA3');