[FAB-4486]Improve integration test for "instantiate CC"

To improve integration test of fabric-sdk-node,
"Instantiate Chaincode" needs negative test cases.
"channel.sendInstantiateProposal(request)" sends an instantiation
proposal to Peers to instantiate Chaincode.
In detail, LSCC (Lifecycle System Chaincode) instantiates
chaincode which is installed on Peers.
We need to add negative test cases to check if sdk gets error
response from Peers in accordance with the check logic in LSCC.

The followings are negative test cases.
- instantiate call fails with non-existent Chaincode version
- instantiate call fails with non-existent Chaincode name
- instantiate call fails by instantiating the same Chaincode twice

This patch has 2 changes.

1. New test code: test/integration/instantiate.js
This test code executes the negative cases above.
To check double instantiation, it contains normal case to
instantiate Chaincode successfully by calling
"test/integration/e2e/e2eUtils.js".

2. modify gulp test: build/tasks/test.js
To execute new test cases with "gulp test", script was modified.
In previous gulp script, tha same test code
"test/integration/e2e/instantiate-chaincode.js" was called twice
to create channel "mychannel" and "mychanneltx".
New gulp test calls "test/integration/instantiate.js" to execute
negative cases at instantiation on "mychanneltx" channel.

Change-Id: Ia31d60b801286f034fed27e99c279e780006d341
Signed-off-by: Yuki Kondo <yuki.kondo@hal.hitachi.com>

build/tasks/test.js

@@ -81,7 +81,7 @@ gulp.task('test', ['clean-up', 'lint', 'pre-test', 'docker-ready', 'ca'], functi
 		'test/integration/get-config.js',
 		'test/integration/create-configtx-channel.js',
 		'test/integration/e2e/join-channel.js',
-		'test/integration/e2e/instantiate-chaincode.js',
+		'test/integration/instantiate.js',
 		'test/integration/e2e/invoke-transaction.js',
 		'test/integration/e2e/query.js',
 		'test/integration/grpc.js'

test/integration/instantiate.js

@@ -0,0 +1,193 @@
+/**
+ * Copyright 2017 Hitachi America Ltd. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+'use strict';
+
+var tape = require('tape');
+var _test = require('tape-promise');
+var test = _test(tape);
+
+var path = require('path');
+var fs = require('fs');
+var util = require('util');
+
+var Client = require('fabric-client');
+var utils = require('fabric-client/lib/utils.js');
+var e2eUtils = require('./e2e/e2eUtils.js');
+var testUtil = require('../unit/util.js');
+var logger = utils.getLogger('instantiate-chaincode');
+
+var e2e = testUtil.END2END;
+var version = 'v0';
+
+test('\n\n **** E R R O R  T E S T I N G : instantiate call fails with non-existent Chaincode version', (t) => {
+	var request = {
+		chaincodeId: e2e.chaincodeId,
+		chaincodeVersion: 'v333333333',
+		fcn: 'init',
+		args: ['a', '500', 'b', '600'],
+		txId: ''
+	};
+
+	var error_snip = 'cannot get package for the chaincode to be instantiated (' + e2e.chaincodeId + ':v333333333' + ')';
+	instantiateChaincodeForError(request, error_snip, t);
+});
+
+test('\n\n **** E R R O R  T E S T I N G : instantiate call fails with non-existent Chaincode name', (t) => {
+	var request = {
+		chaincodeId: 'dummy',
+		chaincodeVersion: version,
+		fcn: 'init',
+		args: ['a', '500', 'b', '600'],
+		txId: ''
+	};
+
+	var error_snip = 'cannot get package for the chaincode to be instantiated (dummy:' + version + ')';
+	instantiateChaincodeForError(request, error_snip, t);
+});
+
+test('\n\n***** End-to-end flow: instantiate chaincode *****\n\n', (t) => {
+	e2eUtils.instantiateChaincode('org1', testUtil.CHAINCODE_PATH, 'v0', false, t)
+	.then((result) => {
+		if(result){
+			t.pass('Successfully instantiated chaincode on the channel');
+
+			return e2eUtils.sleep(5000);
+		}
+		else {
+			t.fail('Failed to instantiate chaincode ');
+			t.end();
+		}
+	}, (err) => {
+		t.fail('Failed to instantiate chaincode on the channel. ' + err.stack ? err.stack : err);
+		t.end();
+	}).then(() => {
+		logger.debug('Successfully slept 5s to wait for chaincode instantiate to be completed and committed in all peers');
+		t.end();
+	}).catch((err) => {
+		t.fail('Test failed due to unexpected reasons. ' + err);
+		t.end();
+	});
+});
+
+test('\n\n **** E R R O R  T E S T I N G : instantiate call fails by instantiating the same Chaincode twice', (t) => {
+	var request = {
+		chaincodeId : e2e.chaincodeId,
+		chaincodeVersion : version,
+		fcn: 'init',
+		args: ['a', '500', 'b', '600'],
+		txId: ''
+	};
+
+	var error_snip = 'chaincode exists ' + e2e.chaincodeId;
+	instantiateChaincodeForError(request, error_snip, t);
+});
+
+function instantiateChaincodeForError(request, error_snip, t) {
+
+	Client.addConfigFile(path.join(__dirname, './e2e/config.json'));
+	var ORGS = Client.getConfigSetting('test-network');
+
+	var caRootsPath = ORGS.orderer.tls_cacerts;
+	let data = fs.readFileSync(path.join(__dirname, '/test', caRootsPath));
+	let caroots = Buffer.from(data).toString();
+
+	var tx_id = null;
+	var the_user = null;
+
+	var userOrg = 'org1';
+	var client = new Client();
+	var channel_name = Client.getConfigSetting('E2E_CONFIGTX_CHANNEL_NAME', testUtil.END2END.channel);
+	logger.debug(' channel_name %s', channel_name);
+	var channel = client.newChannel(channel_name);
+	var orgName = ORGS[userOrg].name;
+	channel.addOrderer(
+		client.newOrderer(
+			ORGS.orderer.url,
+			{
+				'pem': caroots,
+				'ssl-target-name-override': ORGS.orderer['server-hostname']
+			}
+		)
+	);
+
+	var targets = [];
+	for (let org in ORGS) {
+		if (ORGS[org].hasOwnProperty('peer1')) {
+			let key = 'peer1';
+			let data = fs.readFileSync(path.join(__dirname, '/test', ORGS[org][key]['tls_cacerts']));
+			logger.debug(' create new peer %s', ORGS[org][key].requests);
+			let peer = client.newPeer(
+				ORGS[org][key].requests,
+				{
+					pem: Buffer.from(data).toString(),
+					'ssl-target-name-override': ORGS[org][key]['server-hostname']
+				}
+			);
+			targets.push(peer);
+			channel.addPeer(peer);
+		}
+	}
+
+	Client.newDefaultKeyValueStore({
+		path: testUtil.storePathForOrg(orgName)
+	}).then((store) => {
+		client.setStateStore(store);
+		return testUtil.getSubmitter(client, t, true /* use peer org admin */, userOrg);
+	}).then((admin) => {
+		t.pass('Successfully enrolled user \'admin\'');
+		the_user = admin;
+		return channel.initialize();
+	}, (err) => {
+		t.fail('Failed to enroll user \'admin\'. ' + err);
+		throw new Error('Failed to enroll user \'admin\'. ' + err);
+	}).then((nothing) => {
+		t.pass('Successfully initialized channel');
+		request.txId = client.newTransactionID();
+		return channel.sendInstantiateProposal(request);
+	}, (err) => {
+		t.fail(util.format('Failed to initialize the channel. %s', err.stack ? err.stack : err));
+		throw new Error('Failed to initialize the channel');
+	}).then((results) => {
+		checkResults(results, error_snip, t);
+		t.end();
+	}, (err) => {
+		t.fail('Failed to send instantiate proposal due to error: ' + err.stack ? err.stack : err);
+		throw new Error('Failed to send instantiate proposal due to error: ' + err.stack ? err.stack : err);
+	}).catch((err) => {
+		t.fail('Test failed due to unexpected reasons. ' + err);
+		t.end();
+	});
+}
+
+function checkResults(results, error_snip, t) {
+	var proposalResponses = results[0];
+	for(var i in proposalResponses) {
+		let proposal_response = proposalResponses[i];
+		if(proposal_response instanceof Error) {
+			logger.info(' Got the error ==>%s<== when looking for %s', proposal_response,error_snip);
+			if(proposal_response.toString().indexOf(error_snip) > 0) {
+				t.pass(' Successfully got the error '+ error_snip);
+			}
+			else {
+				t.fail(' Failed to get error '+ error_snip);
+			}
+		}
+		else {
+			t.fail(' Failed to get an error returned :: No Error returned , should have had an error with '+ error_snip);
+		}
+	}
+}