Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return clean argument keys #12

Closed
zenangst opened this issue Nov 22, 2015 · 2 comments
Closed

Return clean argument keys #12

zenangst opened this issue Nov 22, 2015 · 2 comments

Comments

@zenangst
Copy link
Contributor

Personally I think it looks kinda weird that the delimiter is included in the arguments dictionary that you get when you resolve arguments. I'd like to strip it out from the key entirely.

Before

Compass.parse(url) { route, arguments in
  XCTAssertEqual("login:{username}:{password}", route)
  XCTAssertEqual(arguments["{username}"], "JohnHyperseed")
  XCTAssertEqual(arguments["{password}"], "secret")
}

After

Compass.parse(url) { route, arguments in
  XCTAssertEqual("login:{username}:{password}", route)
  XCTAssertEqual(arguments["username"], "JohnHyperseed")
  XCTAssertEqual(arguments["password"], "secret")
}
@vadymmarkov
Copy link
Contributor

@zenangst Yeah, totally agree. I was thinking about that too, but forgot to tell you 😄

@zenangst
Copy link
Contributor Author

@vadymmarkov look, a wild pull request appeared 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants