Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespaces #44

Closed
esetnik opened this issue Dec 27, 2016 · 7 comments
Closed

Namespaces #44

esetnik opened this issue Dec 27, 2016 · 7 comments

Comments

@esetnik
Copy link
Contributor

esetnik commented Dec 27, 2016

It looks like the Compass module has the same name as the Compass struct. This causes a problem if the user target also has defined types like Location and Router because they cannot be specified like Compass.Location and Compass.Router. I think to fix this it would be necessary to rename the module something like CompassKit.

https://twitter.com/geeklu/status/674153362200256512
@onmyway133
Copy link
Contributor

@esetnik that 's right. Maybe the Compass struct needs to be renamed to workaround this Swift restriction

@onmyway133
Copy link
Contributor

ping @hyperoslo/ios

@vadymmarkov
Copy link
Contributor

Yes, I agree. We just need a good name 😄

@onmyway133
Copy link
Contributor

Maybe

  • Scout
  • Navigator
  • Journey
  • Square
  • Terminal
  • Jernbanetorget

@vadymmarkov
Copy link
Contributor

Navigator should work I think.

@zenangst
Copy link
Contributor

My vote is on Navigator.

@onmyway133 onmyway133 mentioned this issue Jan 30, 2017
Merged
@onmyway133
Copy link
Contributor

onmyway133 commented Jan 30, 2017 •
edited
Loading

@esetnik Hi, FYI https://github.com/hyperoslo/Compass/releases/tag/5.0.0 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zenangst @esetnik @onmyway133 @vadymmarkov