You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have had some discussions about naming and new API's, one thing that we haven't discuss but has burnt us in the past is the naming of internal components vs framework name. Right now we have an issue with Compass that we use that name in the framework and the framework shares the same name. Because of this, we lose the namespace for that library, which can put us into a deadlock when it comes to conflicts.
I propose that we try and avoid using the framework name inside of the library, in the past we saw this as a necessity but it is causing more problems than it solves.
I see we have fixed this in ImagePicker and Whisper by changing the structs or methods to something else. That it's more hassle to rename the pod name, I'm OK with renaming the internal structs/methods
We have had some discussions about naming and new API's, one thing that we haven't discuss but has burnt us in the past is the naming of internal components vs framework name. Right now we have an issue with
Compass
that we use that name in the framework and the framework shares the same name. Because of this, we lose the namespace for that library, which can put us into a deadlock when it comes to conflicts.I propose that we try and avoid using the framework name inside of the library, in the past we saw this as a necessity but it is causing more problems than it solves.
What do you guys think?
References
hyperoslo/Compass#40 (review)
The text was updated successfully, but these errors were encountered: