Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework names and internals #44

Closed
zenangst opened this issue Oct 11, 2016 · 2 comments
Closed

Framework names and internals #44

zenangst opened this issue Oct 11, 2016 · 2 comments

Comments

@zenangst
Copy link
Contributor

zenangst commented Oct 11, 2016

We have had some discussions about naming and new API's, one thing that we haven't discuss but has burnt us in the past is the naming of internal components vs framework name. Right now we have an issue with Compass that we use that name in the framework and the framework shares the same name. Because of this, we lose the namespace for that library, which can put us into a deadlock when it comes to conflicts.

I propose that we try and avoid using the framework name inside of the library, in the past we saw this as a necessity but it is causing more problems than it solves.

What do you guys think?

References

hyperoslo/Compass#40 (review)

@onmyway133
Copy link
Contributor

I see we have fixed this in ImagePicker and Whisper by changing the structs or methods to something else. That it's more hassle to rename the pod name, I'm OK with renaming the internal structs/methods

@RamonGilabert
Copy link
Contributor

I believe this can be closed and approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants