-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognise both byte and string object for NXdata tag in NeXus reader #112
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 85.20% 85.26% +0.05%
==========================================
Files 73 73
Lines 8991 9030 +39
Branches 2030 2045 +15
==========================================
+ Hits 7661 7699 +38
Misses 871 871
- Partials 459 460 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a test?
Co-authored-by: Eric Prestat <eric.prestat@gmail.com>
Co-authored-by: Eric Prestat <eric.prestat@gmail.com>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
This PR (originally hyperspy/hyperspy#3137) is a small improvement on the NeXus reader, allowing it to recognise NXdata tag as both byte and string object. This increases flexibility and avoid missing genuine NXdata dataset when its tag is saved as a string object.
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),