Fix test suite without optional dependencies #182
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 85.93% 86.02% +0.08%
==========================================
Files 79 81 +2
Lines 10365 10387 +22
Branches 2253 2253
==========================================
+ Hits 8907 8935 +28
+ Misses 936 931 -5
+ Partials 522 521 -1
☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ericpre
force-pushed
the
fix_sparse_numba_optional_test_suite
branch
from
8a3f8d3
to
b3325e8
Compare
ericpre
force-pushed
the
fix_sparse_numba_optional_test_suite
branch
from
b3325e8
to
bc6d9ad
Compare
ericpre
force-pushed
the
fix_sparse_numba_optional_test_suite
branch
from
bc6d9ad
to
c55eb7e
Compare
|
@ericpre I can look at this but just to make sure that I understand are there any changes to the emd readers or are they just split? |
|
Yes, there are just split for the following reasons:
|
rsciio/tests/test_de5.py
Outdated
| @@ -25,6 +25,7 @@ | |||
| import pytest | |||
|
|
|||
| hs = pytest.importorskip("hyperspy.api", reason="hyperspy not installed") | |||
| pytest.importorskip("h5py", reason="hyperspy not installed") | |||
There was a problem hiding this comment.
| pytest.importorskip("h5py", reason="hyperspy not installed") | |
| pytest.importorskip("h5py", reason="h5py not installed") |
There was a problem hiding this comment.
Done, I simplified it by removing the reason argument as it is not necessary.
|
@ericpre This all seems good, but as for this not being caught it might be good to add a CI which only tests the minimal install for RosettaSciIO? |
|
My first comment on not being caught was misleading it wasn't initially, when we merged the PR make some of these optional, but It is now being caught on CI: see the last commit on the main branch: https://github.com/hyperspy/rosettasciio/actions/workflows/tests.yml?query=branch%3Amain |
Okay sounds good then! LGTM You can merge it if you would like |
I am not sure why we didn't caught it earlier but I suspect that that installing hyperspy dev will pull these dependencies...
Progress of the PR
jit_if_numbaintvipsreader,upcoming_changesfolder (seeupcoming_changes/README.rst),docs/readthedocs.org:rosettasciiobuild of this PR (link in github checks)