Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving hspy file with empty array #206

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Dec 18, 2023

Fix #205

Progress of the PR

  • Add support for saving empty array,
  • fix closing hspy file when an error occurs,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • add tests,
  • ready for review.

rsciio/hspy/_api.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (dad4914) 86.19% compared to head (cd5c866) 86.21%.
Report is 2 commits behind head on main.

Files Patch % Lines
rsciio/hspy/_api.py 73.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   86.19%   86.21%   +0.01%     
==========================================
  Files          82       82              
  Lines       10544    10552       +8     
  Branches     2291     2293       +2     
==========================================
+ Hits         9088     9097       +9     
+ Misses        938      935       -3     
- Partials      518      520       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre ericpre changed the title Fix hspy empty array Fix saving hspy file with empty array Dec 18, 2023
@jlaehne jlaehne merged commit 94f9aa9 into hyperspy:main Dec 19, 2023
29 checks passed
@ericpre ericpre added this to the v0.4 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when saving hspy file with empty array
2 participants