Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy 2.0 removal #238

Merged
merged 3 commits into from
Mar 21, 2024
Merged

numpy 2.0 removal #238

merged 3 commits into from
Mar 21, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Mar 20, 2024

Use ruff check . --select NPY201 to find these.

For reference: https://numpy.org/devdocs/release/2.0.0-notes.html#numpy-2-0-python-api-removals.

Progress of the PR

  • Replace deprecated np.string_ by np.bytes_,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • [n/a] add tests,
  • ready for review.

@ericpre ericpre added this to the v0.4 milestone Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.36%. Comparing base (24fc42d) to head (fd8b1d5).

Files Patch % Lines
rsciio/utils/tools.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   86.36%   86.36%           
=======================================
  Files          83       83           
  Lines       10604    10604           
  Branches     2307     2307           
=======================================
  Hits         9158     9158           
  Misses        930      930           
  Partials      516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaehne jlaehne merged commit 0646b2c into hyperspy:main Mar 21, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants