Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate docstring and documentation #38

Closed
ericpre opened this issue Sep 12, 2022 · 2 comments · Fixed by #76
Closed

Consolidate docstring and documentation #38

ericpre opened this issue Sep 12, 2022 · 2 comments · Fixed by #76

Comments

@ericpre
Copy link
Member

ericpre commented Sep 12, 2022

The problem is also, that it is not consistent how detailed the file_reader and file_writer docstrings are. For some formats more is documented in the user guide, for others more in the docstrings.

Originally posted by @jlaehne in #35 (comment)

@ericpre
Copy link
Member Author

ericpre commented Sep 17, 2022

One approach could be to:

  • put the generic/introductory plugin specific documentation a rst/md file for each plugin, which could live in the docs folder or in the plugin folder
  • add the file_reader and file_write docstrings in the plugin specific page of the docs

This could be done by one of the two:

  • use a sphinx template
  • include the API reference in the plugin specific documentation page.

Considering that sphinx is a bit brittle and not always clearly documented, using the sphinx template approach may be more difficult but it would have the advantage of enforcing consistence between plugins and avoid repeating code.

@jlaehne
Copy link
Contributor

jlaehne commented Sep 17, 2022

* put the generic/introductory plugin specific documentation a `rst`/`md` file for each plugin, which could live in the `docs` folder or in the plugin folder

That file exists for every plugin afaik, in docs/supported_formats/.

* add the `file_reader` and `file_write` docstrings in the plugin specific page of the docs

That remains to be done, though some plugins have very detailed docstrings and others none at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants