-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MSA signaltype #39
Conversation
Codecov ReportBase: 82.73% // Head: 82.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 82.73% 82.90% +0.17%
==========================================
Files 40 40
Lines 8032 8042 +10
Branches 1857 1860 +3
==========================================
+ Hits 6645 6667 +22
+ Misses 920 911 -9
+ Partials 467 464 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
99b3935
to
40c99bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it have a changelog entry?
8a2f2b4
to
440ce8d
Compare
440ce8d
to
162a12d
Compare
Description of the change
As brought up in #37, the current implementation of the MSA writer does not comply to the format definitions according to
https://the-mas.org/wp-content/uploads/2018/11/emmff_ascii.txt
In particular, HyperSpy
signal_types
where written to MSA 1:1, even if they deviate from the allowed strings according to the format definition.This PR correctly converts HyperSpy signal strings to the corresponding MSA ones when writing. On the reading side, the resulting
signal_types
don't necessarily correspond to the HyperSpy ones. Correct conversion to signal types of HypersSpy has to be done on the HyperSpy/LumiSpy side (e.g. choosing which voltage corresponds to SEM or TEM) as proposed in #37.Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)Minimal example of the bug fix or the new feature
Note that this example can be useful to update the user guide.