Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when reading Velox file containing FFT with odd number of pixels #49

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Oct 9, 2022

Port hyperspy/hyperspy#3040 to RosettaSciIO with test files as provided by @bryandesser.

Progress of the PR

  • Add missing dtype to list of expected dtype for complex signal,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • add tests,
  • ready for review.

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 83.37% // Head: 83.37% // No change to project coverage 👍

Coverage data is based on head (6689b57) compared to base (8176d44).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   83.37%   83.37%           
=======================================
  Files          40       40           
  Lines        8337     8337           
  Branches     1896     1896           
=======================================
  Hits         6951     6951           
  Misses        911      911           
  Partials      475      475           
Impacted Files Coverage Δ
rsciio/emd/api.py 85.34% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jlaehne jlaehne merged commit c85d091 into hyperspy:main Oct 17, 2022
@jlaehne jlaehne mentioned this pull request Nov 15, 2022
7 tasks
@jlaehne jlaehne mentioned this pull request Dec 7, 2022
7 tasks
@jlaehne jlaehne mentioned this pull request Jan 16, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants