Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_log_level for rosettasciio is needed #69

Closed
Tracked by #99
nem1234 opened this issue Nov 28, 2022 · 2 comments · Fixed by #192
Closed
Tracked by #99

set_log_level for rosettasciio is needed #69

nem1234 opened this issue Nov 28, 2022 · 2 comments · Fixed by #192
Labels
type: new feature
Milestone
v0.3

Comments

@nem1234
Copy link
Contributor

nem1234 commented Nov 28, 2022

Describe the functionality you would like to see.

Like hyperspy's hs.set_log_level function, rosettasciio.set_log_level is needed.
May be hs.set_log_level should also control rsciio.set_log_level.
@ericpre
Copy link
Member

ericpre commented Nov 29, 2022

Like hyperspy's hs.set_log_level function, rosettasciio.set_log_level is needed.

Yes, indeed it would be convenient to have something similiar.

May be hs.set_log_level should also control rsciio.set_log_level.

In principle, it should stay separated.

@nem1234
Copy link
Contributor Author

nem1234 commented Nov 30, 2022 •
edited
Loading

In principle, it should stay separated.

I agree it, but, currently no warning messages are shown while loading files from hyperspy.
Setting default logging level of WARNING seems useful.

@jlaehne jlaehne added this to the v0.1.0 initial release milestone Jan 16, 2023
@jlaehne jlaehne mentioned this issue Apr 17, 2023
Closed
19 tasks
@ericpre ericpre removed this from the v0.1.0 initial release milestone Jun 6, 2023
@ericpre ericpre added this to the v0.2 milestone Jul 8, 2023
@ericpre ericpre modified the milestones: v0.2, v0.3 Nov 8, 2023
@ericpre ericpre mentioned this issue Dec 2, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: new feature
Projects
None yet
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

Add rsciio.set_log_level to set the logging level ericpre/rosettasciio
3 participants
@jlaehne @ericpre @nem1234