Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] i18n, but with a good library #669

Closed
tyn1998 opened this issue May 14, 2023 · 1 comment
Closed

[Feature] i18n, but with a good library #669

tyn1998 opened this issue May 14, 2023 · 1 comment
Labels
kind/feature Category issues or prs related to feature request. waiting for author

Comments

@tyn1998
Copy link
Member

tyn1998 commented May 14, 2023

Description

The current used DIY i18n support is indeed embarrassing:

export function getMessageByLocale(key: string, locale: string) {
// @ts-ignore
return messages_locale[locale][key]['message'];
}

We should take a research on related libraries then switch to a good one. Also remove keys no longer used.

@tyn1998 tyn1998 added the kind/feature Category issues or prs related to feature request. label May 14, 2023
@wxharry
Copy link
Collaborator

wxharry commented May 15, 2023

Agree. It is unnecessary for each feature to fetch the locale settings to get message. And things like that would make coding harder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Category issues or prs related to feature request. waiting for author
Projects
Status: No status
Development

No branches or pull requests

2 participants