Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range not updated when properties change #5

Closed
aommm opened this issue Oct 14, 2015 · 1 comment · Fixed by #6
Closed

Range not updated when properties change #5

aommm opened this issue Oct 14, 2015 · 1 comment · Fixed by #6
Labels
bug
Milestone
v0.1.7

Comments

@aommm
Copy link
Contributor

aommm commented Oct 14, 2015

When I include and afterwards change x or y in the parent component, DateRange is not updated.

This is because DateRange doesn't use the props directly, but parses them and puts them into state, and this is only done in the constructor, and then never again.
@aommm aommm mentioned this issue Oct 14, 2015
Merged
@burakcan burakcan added the bug label Oct 14, 2015
@burakcan burakcan added this to the v0.5.6 milestone Oct 14, 2015
@burakcan burakcan reopened this Oct 19, 2015
@aommm aommm mentioned this issue Oct 19, 2015
Merged
@burakcan
Copy link
Collaborator

thanks @aommm :)
published v0.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.1.7
Development

Successfully merging a pull request may close this issue.

Bug/range not updated aommm/react-date-range
2 participants
@aommm @burakcan