Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TypeScript types #10

Closed
hyunbinseo opened this issue Jul 19, 2023 · 2 comments
Closed

Improve TypeScript types #10

hyunbinseo opened this issue Jul 19, 2023 · 2 comments
Assignees
@hyunbinseo
Labels
enhancement New feature or request

Comments

@hyunbinseo
Copy link
Owner

Analysis of @hyunbinseo/holidays-kr@2.2024.1

Masquerading as CJS

Import resolved to a CommonJS type declaration file, but an ESM JavaScript file.

Used fallback condition

Import resolved to types through a conditional package.json export, but only after failing to resolve through an earlier condition. This behavior is a TypeScript bug. It may misrepresent the runtime behavior of this import and should not be relied upon.

"@hyunbinseo/holidays-kr"
node10 ✅
node16 (from CJS) ✅ (CJS)
node16 (from ESM) Masquerading as CJS
Used fallback condition
bundler Used fallback condition
@hyunbinseo hyunbinseo added the enhancement New feature or request label Jul 19, 2023
@hyunbinseo hyunbinseo self-assigned this Jul 19, 2023
@hyunbinseo
Copy link
Owner Author

Generate separate type files for CJS and MJS. Hopefully fixed by tsup@7.1.0.

@hyunbinseo
Copy link
Owner Author

Fixed in v2.2024.4

https://arethetypeswrong.github.io/?p=%40hyunbinseo%2Fholidays-kr%402.2024.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyunbinseo hyunbinseo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hyunbinseo