Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom server support #782

Closed
mercteil opened this issue Jul 30, 2020 · 1 comment
Closed

Custom server support #782

mercteil opened this issue Jul 30, 2020 · 1 comment

Comments

@mercteil
Copy link

Why would you remove the custom server support?

I use custom route patterns and some other middlewares in my project (eg. also next-i18next).

From v5.0 it makes it extremely hard for me to update this package since I would probably rewrite and refactor a lot of code.

Isn't it possible to return the middleware functionality for custom servers ?

@isaachinman
Copy link
Contributor

Custom servers are actively discouraged by the NextJs team, and for pretty good reasons. It was a "hack" in some sense, that this package used for quite some time to support specific cookie/middleware/redirect functionality.

I won't be actively maintaining support for custom servers, because now that we have rewrites and have removed our Express dependency, they simply aren't necessary. All version previous to v5.0.0 support custom servers, and can be used as long as you'd like – no need to refactor immediately.

For an idea of what an upgrade path would look like, you can check: #689 (comment). I'm hoping to gather more information like this and update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants