Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need info about common.json file in docs #812

Closed
MareoRaft opened this issue Apr 3, 2019 · 5 comments
Closed

Need info about common.json file in docs #812

MareoRaft opened this issue Apr 3, 2019 · 5 comments

Comments

@MareoRaft
Copy link

Describe the bug
This is a request for documentation improvement. Need more info on where to put common.json in the step-by-step guide.

Additional context
The most recent step by step guide (https://react.i18next.com/latest/using-with-hooks) shows you how to set up a project in such a way that it depends on a common.json translations file, as far as I can tell. But none of the steps in the guide say to create this file, where to put the file, and what the content of the file should be. This should probably be one of the first steps.

Thank you!

@jamuhl
Copy link
Member

jamuhl commented Apr 4, 2019

Added a link to https://github.com/i18next/react-i18next/tree/master/example/react/public/locales should hopefully sufficient to show this (location always depend on your i18next backend settings)

@jamuhl
Copy link
Member

jamuhl commented Apr 4, 2019

If you got a better idea - a PR on docs would be highly appreciated

@MareoRaft
Copy link
Author

I won't be able to make a PR because I wasn't able to get things working with i18next-xhr-backend, which is what the docs want you to use.

@MareoRaft
Copy link
Author

actually, this issue should remain open since it is still an outstanding issue

@MareoRaft MareoRaft reopened this Apr 5, 2019
@jamuhl
Copy link
Member

jamuhl commented Apr 5, 2019

There is a big difference not getting it working (= stackoverflow) and there is a bug in the code -> as long there is no bug there is no need to keep an issue open.

there is the examples folder with a working sample...https://github.com/i18next/react-i18next/tree/master/example/react

In case you need more information about the xhr-backend: https://github.com/i18next/i18next-xhr-backend#backend-options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants