Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter Subscription Support #6

Closed
sprankhub opened this issue Dec 12, 2022 · 4 comments
Closed

Newsletter Subscription Support #6

sprankhub opened this issue Dec 12, 2022 · 4 comments

Comments

@sprankhub
Copy link
Contributor

I see that there is quite a bit of code regarding the newsletter subscription already. However, most of it is "disabled" and it seems to be not supported at the moment. Could you share some insights? What does it take to add newsletter support? Thanks!

@amenk
Copy link
Member

amenk commented Dec 12, 2022

@DanieliMi can you share some pointers on this?

@DanieliMi
Copy link
Member

What is currently commented is the bare minimum copied. In order to get it working it needs to be uncommended and the template view/frontend/templates/imi_friendly_captcha_newsletter.phtml must be adjusted. The attributes, data-sitekey, data-puzzle-endpoint, data-lang and data-callback need to be implemented as does the according javascript. I think it will be very similar to view/frontend/templates/imi_friendly_captcha.phtml.

Once the template is implemented it should technically work already since the observer already exists.

@sprankhub
Copy link
Contributor Author

See #17.

@DanieliMi
Copy link
Member

@sprankhub thank you for your contribution! I just released 1.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants